Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close input on <Esc> #1

Closed
bsander opened this issue Dec 4, 2021 · 4 comments · Fixed by #102
Closed

Close input on <Esc> #1

bsander opened this issue Dec 4, 2021 · 4 comments · Fixed by #102

Comments

@bsander
Copy link

bsander commented Dec 4, 2021

This plugin looks great! I have a hard time canceling a rename operation though, pressing Escape just changes to normal mode but doesn't close the rename input modal. Seems like I need to explicitly close the window for that. Am I missing something? I think pressing Escape should close the window and cancel the renaming.

@mel10c
Copy link

mel10c commented Dec 4, 2021

Yeah, seems that this problem is only present for the input section, the selection section would work exist properly with the Escape button.

@stevearc
Copy link
Owner

stevearc commented Dec 4, 2021

Sounds like a good idea to me!

@axieax
Copy link
Contributor

axieax commented Dec 5, 2021

Hello, not sure but can anyone else reproduce this issue? I'm trying to use vim.lsp.buf.rename.

dressing.mp4

@stevearc
Copy link
Owner

stevearc commented Dec 5, 2021

Apologies, should be fixed now. I was using a :command mapping instead of <cmd> to force the completion window to close (if it was visible), but that caused this issue. Refactored it to close the window in a more reliable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants