Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bind keymap, add number prefix #104

Merged
merged 4 commits into from
Jul 17, 2023
Merged

feat: bind keymap, add number prefix #104

merged 4 commits into from
Jul 17, 2023

Conversation

cathaysia
Copy link
Contributor

just like this:

image

@cathaysia
feat(select/builtin): binding keymap for select
cd1011e 
Signed-off-by: Longtao Zhang <DragonBillow@outlook.com>
@cathaysia
feat(select/builtin): add number prefix
6f353fd 
Signed-off-by: Longtao Zhang <DragonBillow@outlook.com>
stevearc
stevearc requested changes Jul 14, 2023
View reviewed changes
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove the debug print statement

lua/dressing/select/builtin.lua Outdated

vim.api.nvim_buf_set_keymap(bufnr, "n", tostring(idx), "", {
callback = function()
print(0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@cathaysia
style(builtin): remove debug statement
9218498 
Signed-off-by: Longtao Zhang <DragonBillow@outlook.com>
@cathaysia
style(builtin): rename variable, solve luacheck problem
4864cf9 
Signed-off-by: Longtao Zhang <DragonBillow@outlook.com>
@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit cc69bfe into stevearc:master Jul 17, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc stevearc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cathaysia @stevearc