Ensure 16-byte alignment for amd64 coroutine stack #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AMD64 ABI requires that stacks be 16-byte aligned. stackend is going to be 16-byte aligned, 128 is a multiple of 16, and sizeof(uintptr_t) is going to 8 on amd64, so this results in a stack that is not 16-byte aligned on amd64 (at least for platforms where this code branch is used, such as OpenBSD). This results in bus errors when floating point numbers are converted to strings, since snprintf calls movaps with a non 16-byte aligned memory location. With this patch, the iovm correctness tests pass on OpenBSD/amd64.
stevedekorte
added a commit
that referenced
this pull request
Oct 12, 2012
Ensure 16-byte alignment for amd64 coroutine stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMD64 ABI requires that stacks be 16-byte aligned. stackend is
going to be 16-byte aligned, 128 is a multiple of 16, and
sizeof(uintptr_t) is going to 8 on amd64, so this results in a stack
that is not 16-byte aligned on amd64 (at least for platforms where
this code branch is used, such as OpenBSD). This results in bus errors
when floating point numbers are converted to strings, since snprintf
calls movaps with a non 16-byte aligned memory location.
With this patch, the iovm correctness tests pass on OpenBSD/amd64.