Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change builtin tparam aliases to expand to full type names #246

Merged
merged 1 commit into from Apr 29, 2023
Merged

Change builtin tparam aliases to expand to full type names #246

merged 1 commit into from Apr 29, 2023

Conversation

mpeterv
Copy link
Contributor

@mpeterv mpeterv commented Jul 23, 2016

I expected @tab to be same as @tparam table, including linking to table docs, but instead it means @tparam tab. This PR changes some built-in tparam aliases to expand to full type names.

@mpeterv
Change builtin tparam aliases to expand to full type names
deec0f1 
'@int' now means '@tparam integer' instead of '@tparam int'.
'@Bool' now means '@tparam boolean' instead of '@tparam bool'.
'@func' now means '@tparam function' instead of '@tparam func'.
'@tab' now means '@tparam table' instead of '@tparam tab'.
alerque
alerque reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute.

This makes perfect sense to me, but won't this be a breaking change for some people's configs? Wouldn't we want to keep both the original aliases and these for least disruption in usage?

alerque
alerque approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R.I.P.

@alerque alerque merged commit f2fa057 into lunarmodules:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpeterv @alerque