Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using phpcbf to enable automatically fixing minor items #6

Closed
bswatson opened this issue Nov 30, 2015 · 3 comments
Closed

Allow using phpcbf to enable automatically fixing minor items #6

bswatson opened this issue Nov 30, 2015 · 3 comments
Milestone

Comments

@bswatson
Copy link
Collaborator

PHP Code Beautifier and Fixer can be used to automatically fix many common or minor issues and would be great as an additional option.

@stevegrunwell
Copy link
Owner

Ooh, good call! I'm not a fan of that becoming the default behavior, but considering it's swapping out an executable (that's already present, as it comes in with PHP_CodeSniffer) it wouldn't be difficult to add a --phpcbf (or similar) flag to the installer to copy use that program in the hook instead.

@stevegrunwell stevegrunwell added this to the 0.4.0 milestone Nov 30, 2015
@stevegrunwell stevegrunwell modified the milestones: 0.5.0, 0.4.0 Dec 2, 2015
@ghost
Copy link

ghost commented May 20, 2017

I'm not a fan of that becoming the default behavior

Agreed. A tool should never automatically modify someone's code. It should provide feedback and instruction to help them modify it themselves, whether done using a tool or an editor.

Please consider closing this issue if there is no follow-up action to be done here.

@stevegrunwell
Copy link
Owner

I'm going to lean on keeping this out of WP Enforcer, but there's a section within the adding to an existing project section of the README that covers phpcbf usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants