Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding repository for init containers in Nexus helm chart #850

Open
jmccrumm opened this issue Dec 13, 2023 · 2 comments · May be fixed by #852
Open

Allow overriding repository for init containers in Nexus helm chart #850

jmccrumm opened this issue Dec 13, 2023 · 2 comments · May be fixed by #852

Comments

@jmccrumm
Copy link
Contributor

We install the nexus3 helm charts using our own custom core registry (we have a registry containing the nexus3 images only, then nexus3 itself serves up the images for all our normal services). That being said, we override the image.repository helm value to point to this custom core registry. However, the initContainers in the deployment.yaml (and statefulset.yaml) hardcode the image values, forcing us to make edits to those specs manually. It would be convenient if the init containers could override the repository they are obtained from via helm values as well.
@stevehipwell
Copy link
Owner

@jmccrumm I'd be willing to add values to override the init container image but it's not implicitly related to the primary image so the current values aren't relevant. I was already planning on changing the default to a Chainguard image for zero CVEs.

@jmccrumm
Copy link
Contributor Author

@stevehipwell Sounds great, thank you!

@stevehipwell stevehipwell linked a pull request Dec 15, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nexus3): Updated init container spec stevehipwell/helm-charts
2 participants
@stevehipwell @jmccrumm