Fix warning: catching polymorphic type ‘class Grantlee::Exception’ by…

… value [-Wcatch-value=]
steveire · Apr 15, 2019 · 474472c · 474472c
1 parent 3cb4bd2
commit 474472c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/templates/defaulttags/if.cpp b/templates/defaulttags/if.cpp
@@ -92,7 +92,7 @@ void IfNode::render(OutputStream *stream, Context *c) const
     if (pair.first) {
       try {
         match = Grantlee::variantIsTrue(pair.first->evaluate(c));
-      } catch (Grantlee::Exception) {
+      } catch (const Grantlee::Exception &) {
       }
     } else {
       match = true;

diff --git a/templates/defaulttags/if_p.h b/templates/defaulttags/if_p.h
@@ -321,7 +321,7 @@ QVariant IfToken::evaluate(Context *c) const
       Q_ASSERT(!"Invalid OpCode");
       return QVariant();
     }
-  } catch (Grantlee::Exception) {
+  } catch (const Grantlee::Exception &) {
     return false;
   }
 }

diff --git a/templates/lib/parser.cpp b/templates/lib/parser.cpp
@@ -205,7 +205,7 @@ NodeList ParserPrivate::parse(QObject *parent, const QStringList &stopAt)
       FilterExpression filterExpression;
       try {
         filterExpression = FilterExpression(token.content, q);
-      } catch (Grantlee::Exception e) {
+      } catch (const Grantlee::Exception &e) {
         throw Grantlee::Exception(e.errorCode(),
                                   QStringLiteral("%1, line %2, %3")
                                       .arg(e.what())
@@ -247,7 +247,7 @@ NodeList ParserPrivate::parse(QObject *parent, const QStringList &stopAt)
       Node *n;
       try {
         n = nodeFactory->getNode(token.content, q);
-      } catch (Grantlee::Exception e) {
+      } catch (const Grantlee::Exception &e) {
         throw Grantlee::Exception(e.errorCode(),
                                   QStringLiteral("%1, line %2, %3")
                                       .arg(e.what())