fix(context.version): only valid a semver can decide context.isPatch

conventional-changelog-archived-repos · Feb 3, 2016 · 59ed325 · 59ed325
1 parent 0cc1d01
commit 59ed325
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/util.js b/lib/util.js
@@ -168,7 +168,7 @@ function generate(options, commits, context, keyCommit) {
     context.date = keyCommit.committerDate;
   }
 
-  if (context.version) {
+  if (context.version && semver.valid(context.version)) {
     context.isPatch = context.isPatch || semver.patch(context.version) !== 0;
   }
 

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -652,6 +652,21 @@ describe('conventionalChangelogWriter', function() {
       }));
   });
 
+  it('should not error if version is not semver', function(done) {
+    getStream()
+      .pipe(conventionalChangelogWriter({
+        version: 'a.b.c'
+      }))
+      .on('error', function(err) {
+        done(err);
+      })
+      .pipe(through(function(chunk) {
+        expect(chunk.toString()).to.include('a.b.c');
+
+        done();
+      }));
+  });
+
   it('should callback with error on transform', function(done) {
     getStream()
       .pipe(conventionalChangelogWriter({}, {