Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): input is mutated by normalize-package-data #13

Merged
merged 1 commit into from Dec 2, 2017
Merged

docs(README): input is mutated by normalize-package-data #13

merged 1 commit into from Dec 2, 2017

Conversation

hutson
Copy link
Contributor

@hutson hutson commented Nov 14, 2017

Fixes #12.

@hutson hutson added the documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors. label Nov 14, 2017
@hutson hutson self-assigned this Nov 14, 2017
@hutson hutson requested a review from stevemao November 14, 2017 16:24
@hutson
Copy link
Contributor Author

hutson commented Nov 14, 2017

cc @revelt

@hutson
Copy link
Contributor Author

hutson commented Nov 14, 2017

@stevemao looks like CI isn't passing because tests are executed on older versions of Node that don't support the features of this code base.

Suggestions for moving forward?

@hutson
Copy link
Contributor Author

hutson commented Nov 14, 2017

I committed 7c618bc to the master branch to update the Node versions in Travis CI.

Looks like a dependency of get-pkg-repo changed their minimum version of Node supported.

@revelt
Copy link

revelt commented Nov 14, 2017

Good job. Node versions less than v.4 are deprecated anyway and 4 seems to pass fine. It's ES6 arrows in supports-color.

@hutson hutson merged commit 51959f2 into master Dec 2, 2017
@hutson hutson deleted the docs/readme/mutation branch December 2, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemao stevemao stevemao approved these changes

Assignees

@hutson hutson

Labels
documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hutson @revelt @stevemao