feat: add cursor-pointer to question-circles #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to find the root of the issue but failed, lol. @steven-tey, do you have an idea on what's going on? |
|
@rwlc that's because I should've made the responsive modal feature I added that day work on iPad as well! It's fine though, we can merge this for now! :) |
|
Actually, a11y standards prefer if you use the default cursor for non-interactive tooltips: https://ux.stackexchange.com/questions/103115/tooltip-css-cursor Reverting this for now, sorry for the trouble! I misunderstood what you meant in #57 – I thought you were talking about the tooltip for the bar charts! Apologies again! 😅 |
|
Oh alright. No problem at all!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57
However, while debugging on iPad screens, I noticed that tooltips don't work. No modal pops out when you click on it. I'm not sure what the root cause of this issue is -- but I am able to reproduce this on my iPad, so there is definitely some weird thing happening.
p.s - a hacktoberfest-accepted label would be great! :)