Selecting Manage Favorites Causes crash

[julie777]

Problem to Solve

When I select "manage favorites" from the Favorites menu, or with the 2 dots from the favorite chooser dialog, or while in settings, it causes a crash.

Several times I just selected continue because I was in the process of writing up another issue.
Eventually it really messed up OneMore and I shut down OneNote. (It was so strange, I accidentally clicked on styles instead of favorites and it just showed 4 tiny icons, instead of the normal styles menu.)

I tried removing the last favorite I added from favorites.xml to see if that was the problem but the crash still happens. I have no idea when this behavior started because I don't remember the last time I view the settings for favorites.

I have included

• the OneMore log
• the details from the crash dialog
• my favorites file (renamed .txt)

To Reproduce

Steps to reproduce the behavior:

1. Open Favorites Menu
2. Click Manage Favorites
3. Crash
4. Select Continue and the favorites table shown is empty
5. OneMore is left very confused and OneNote needs to be restarted.

Expected Behavior

Show the settings for favorites.

Screenshots

Environment (if applicable)

• OneNote Version: O365,
• OneMore Version 5.8.4 with OneNote 16.0.16130.20332

Additional Context

OneMore.log
error from dialog.txt
Favorites.txt

[stevencohn]

There's likely another favorite in your list that's orphaned, not just the last one. That table attempts to cross-check each favorite with its source and tags it as suspicious or unknown depending on what it can or cannot find.

It should crash currently for you if you choose the Check Favorites item from the three-dot menu as well. That's the same function

[julie777]

I'm not sure what you mean by the three dot menu.

@stevencohn Are you planning to fix the crash or is that by design? ;-)

[julie777]

I just found two orphaned links by just trying to go to the favorite.

They bring up a long series of message boxes in the process. I can't believe that it takes this many messages just to say "it doesn't exist".

This is what happens when I say yes I want to ignore safety and follow the link.
I assume that this mess is all Microsoft.

[stevencohn]

Will be fixed with the next releease. This is the three-dot menu

[julie777]

Not for me

I even made the dialog wider to see if the third dot would appear.
I just realized that you are using a different version because your three dots has a dropdown and mine goes straight to settings.