Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Defaults for "Images->Resize and Adjust" Command #857

Closed
JRPX33 opened this issue Jan 30, 2023 · 8 comments · Fixed by #861
Closed

Set Defaults for "Images->Resize and Adjust" Command #857

JRPX33 opened this issue Jan 30, 2023 · 8 comments · Fixed by #861
Labels
feature-request New feature or request released Available in a released installer

Comments

@JRPX33
Copy link
Sponsor

JRPX33 commented Jan 30, 2023

I'm Really loving the "Resize and Adjust" Command --- I have a bunch of OneNote notebooks with HUGE images that are making the notebooks unmanageable and I've never seen a command like this on any other add-in.

However, it would be even more awesome if I could change the default settings of the command to be 100% and uncheck "preserve storage size". I'm finding i have to reset these with each page I resize.

@stevencohn stevencohn added the feature-request New feature or request label Jan 30, 2023
@stevencohn
Copy link
Owner

The default settings are designed to default to no-data-loss.

Currently, this dialog will remember the most-recently-used absolute width but it does not remember the percentage or the state of the preserve checkbox.

I can enhance it to remember all settings. Although, I'm considering whether that should reset when you close OneNote or persist... preferences?

@JRPX33
Copy link
Sponsor Author

JRPX33 commented Jan 30, 2023

Excellent point, having destructive defaults could lead to problems.

a few ideas:

  1. Have a checkbox or button that says "Remember these settings for this session"

  2. Have a preference that will allow it to persist through sessions...but have a red highlight in the dialog that says "Image detail will be lost" or something. That would be my preference, since that's basically ALWAYS what I want. But this could remind others to turn the feature off if they don't want that.

  3. In looking at the latest version (I'm a bit behind because I got caught in the autoupdate thing:-) , I like the Lock next to height/width. Maybe you could just put a lock next to "preserve storage size" and then any time preserve storage size is unchecked, have text below it warning that image resolution will be lost.

Thanks for looking into this!

@stevencohn
Copy link
Owner

The lock is a Photoshop-thing that maintains the aspect ratio between width and height. Unlock it to change the aspect ratio.

Proposed solution is to somehow highlight controls that affect data loss, probably tooltips. Persist settings. And provide a "Reset defaults" button. Simple.

@stevencohn stevencohn linked a pull request Jan 31, 2023 that will close this issue
@stevencohn stevencohn added the next-release Addressed but not yet released label Jan 31, 2023
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Feb 7, 2023
@koppor
Copy link
Sponsor

koppor commented Dec 16, 2023

I can enhance it to remember all settings.

Yes, please! I always need to change 100 to 50in the resize box.

Reason: When pasting a picture, it is "always" twice the desired size. That means: The pasted size (Refs #934)


Example:

image


Although, I'm considering whether that should reset when you close OneNote or persist... preferences?

I would like to have it persisted permanently, because I do not change the setting.

What would be nice, is a button "reset to defaults"

image

@stevencohn
Copy link
Owner

This work was completed in Jan 2023 and has been included for a couple of releases. It saves settings and has a reset defaults button.

FYI, there will be a new release in the next few days so you may want to wait for that! :-)

@koppor
Copy link
Sponsor

koppor commented Dec 16, 2023

This work was completed in Jan 2023 and has been included for a couple of releases. It saves settings and has a reset defaults button.

Here, version 5.9.0 does NOT remember the setting for "Percentage" (point 1 in the screenshot), but it has "Reset default values" at the bottom (point 2).

image

@stevencohn
Copy link
Owner

Yes, sorry I should have pointed out. Percentage was purposely excluded with the idea that it likely doesn't apply globally, for various reasons. But maybe that idea was too conservative, trying to protect the innocent.

I can certainly include it, that's easy enough.

@stevencohn
Copy link
Owner

Funny story. Looking at the code, it appears to be a bug and everything should have been saved all along! 😆
I'll fix it for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants