Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input is flagged as changing during prepImage even if HTML did not change #86

Closed
stevengharris opened this issue Jan 17, 2023 · 0 comments · Fixed by #85
Closed

Input is flagged as changing during prepImage even if HTML did not change #86

stevengharris opened this issue Jan 17, 2023 · 0 comments · Fixed by #85

Comments

@stevengharris
Copy link
Owner

The prepImage function in markup.js ensures that images are resizable, selectable, and specify their width and height. In prepImage, we _callback('input') when done. Ultimately this causes the HTML to be fetched on the Swift side even in the case when prepImage made no changes to the HTML. This seems like a minor change, but if you are relying on callbacks to 'input' to indicate changes in the document, these are both unnecessary and may have side-effects for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant