Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table toolbar presentation/dismissal issues #93

Closed
stevengharris opened this issue Feb 28, 2023 · 0 comments · Fixed by #95
Closed

Table toolbar presentation/dismissal issues #93

stevengharris opened this issue Feb 28, 2023 · 0 comments · Fixed by #95

Comments

@stevengharris
Copy link
Owner

In environments with a non-hardware keyboard, the MarkupToolbar is presented as an inputAccessoryView with the keyboard. The TableToolbar is presented as a SubToolbar that extends from the MarkupToolbar. This approach works okay for the Mac, but it presents (pun intended) problems on dismissal. For example, when the TableSizer is presented, and the user drags across the grid, the TableSizer should be dismissed when the drag is complete. This doesn't work on iOS.

The second issue with the TableToolbar presentation is that when the MarkupToolbar is embedded in another view's toolbar along with other ToolbarItems, the SubToolbar type of style of extending from the MarkupToolbar just looks bad. The SubToolbar extends for the MarkupToolbar width, but the MarkupToolbar is embedded in a larger toolbar, so the SubToolbar is a kind of stub that extends below the larger toolbar and looks weird.

The TableToolbar should be presented as a .popover from the "insert table" button of the InsertToolbar. This behavior would also be consistent with the link and image presentation approach when those buttons are pressed.

@stevengharris stevengharris linked a pull request Feb 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant