Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a bare module with no imports for @pyimport #110

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

simonster
Copy link
Member

This avoids warnings about conflicting imports

@simonster
Copy link
Member Author

Hmm, I thought this would work since the Module constructor just calls jl_f_new_module, which doesn't do much else, and it does indeed suppress the warning, but it seems that there's printing code that expects modules to have parents, and I'm not sure how to set that from Julia (yet).

This avoids warnings about conflicting imports
@simonster
Copy link
Member Author

This is pretty ugly, but it looks like it works. A better long-term approach might be to extend the Module constructor to allow creation of baremodules.

stevengj added a commit that referenced this pull request Jan 5, 2015
Use a bare module with no imports for @pyimport
@stevengj stevengj merged commit dc35a81 into JuliaPy:master Jan 5, 2015
@stevengj
Copy link
Member

stevengj commented Jan 5, 2015

Thanks.

@stevengj
Copy link
Member

stevengj commented Jan 5, 2015

(Gotta fix that Julia 0.3 failure, but that seems unrelated to your patch. Unfortunately, I can't seem to replicate that failure locally.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants