-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP towards make PyCall use Conda if system python is not found #191
Conversation
The difficulty with this is that many people using PyCall will be Python users who want to call Python packages that they've installed by their familiar way in Python. If PyCall uses Conda's Python, they will be surprised because it won't find any of the packages they've installed with their regular Python. |
Yes that is the reasoning about not requiring Conda, but if Conda is installed then it prefers the python distribution in Conda. This means the changes will not affect people having a system wide python and do not have Conda installed. |
68ea404
to
d72452e
Compare
I have updated the PR. The miniconda python distribution in Conda only takes up 123 MB when nothing is installed which acceptable. I have added a |
@@ -1,4 +1,7 @@ | |||
using Base.Test, PyCall, Compat | |||
import Conda | |||
|
|||
PyCall.use_conda && Conda.add("numpy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably Conda.add("numpy")
should be done in Pkg.build
, since it is generally a good idea to have NumPy with PyCall, to support zero-copy arrays.
Would be good to have Travis testing too. Maybe just add Python 2.6 to the Travis tests, if that is allowed by Travis. With the version check I suggested above, that will force Pkg.build to use Conda. |
I have addressed your comments. Maybe you could cancel the old appveyor build to reduce the load on appveyor. |
cancelled the build. |
Travis is failing with Probably, (I don't understand why they couldn't just use the same paths on Unix and Windows.) |
I have made a PR to |
Because they reproduce the way Python is packaged on Windows. But I have no idea why it was done so for Python in the first place. |
endless frustration caused by someone deciding to be different on different platforms decades ago |
Everything is passing now. |
WIP towards make PyCall use Conda if system python is not found
Thanks! |
This is a WIP towards figuring out how Conda can be used as a replacement of system python and it is parallel work to JuliaLang/IJulia.jl#357.
I still haven't figured out the API for how PyPlot/PyCall/IJulia should interact with Conda and if they should require Conda or if the user should add Conda.