Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated FileOffset #223

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Remove deprecated FileOffset #223

merged 1 commit into from
Jan 11, 2016

Conversation

yuyichao
Copy link
Collaborator

@yuyichao
Copy link
Collaborator Author

As Jameson pointed out, sizeof(FileOffset) is always 8 on all the platforms we support. (And I pushed a test commit to check and it is indeed the case) so I've removed the version check and always use Int64 on all versions.

stevengj added a commit that referenced this pull request Jan 11, 2016
@stevengj
Merge pull request #223 from yuyichao/dep-off_t
a6f3998 
Remove deprecated FileOffset
@stevengj stevengj merged commit a6f3998 into JuliaPy:master Jan 11, 2016
@yuyichao yuyichao deleted the dep-off_t branch January 11, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuyichao @stevengj