Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSL viewer suddenly not loading #45

Closed
ianacaburian opened this issue Mar 30, 2019 · 12 comments · Fixed by #46
Closed

GLSL viewer suddenly not loading #45

ianacaburian opened this issue Mar 30, 2019 · 12 comments · Fixed by #46
Assignees
Labels

Comments

@ianacaburian
Copy link

Hey there, see image below. This happens after trying to open the GLSL viewer on a file that has worked previously. As you can see there is no error log displayed as usual - only grey boxes. Not sure what else to try or where to go from here. Thanks in advance for the help.

Screen Shot 2019-03-31 at 4 03 13 am

@Malacath92
Copy link

Does this happen for any shader for you? If not, can you produce a minimum working example.
Which platform are you on?
Which version of VS Code are you running?

@edap
Copy link

edap commented Apr 4, 2019

This is also happening to me. Any shader has the same output. Even a dummy:

vec2 vectorField(vec2 uv){
  vec2 res = uv;
  res.x += sin(res.y*30.5) * 0.01;
  return res;
}

void main(){
  vec2 st = gl_FragCoord.xy / iResolution.xy;
  st.y *= iResolution.y / iResolution.x;
  st = vectorField(st);

  vec3 col = vec3(1.0,0.,0.) * step(st.x, 0.5);
  gl_FragColor = vec4(col,1.0);
}

Produce the same result as @ianacaburian was posting.

I am on Mac, Code version 1.32

@uniformfake
Copy link

I have the same symptoms.

I am on Mac0S Mojave 10.14.4 / VSCode 1.33

@nickkuk
Copy link

nickkuk commented Apr 6, 2019

Ubuntu Linux / VSCode 1.33 - the same.

@Malacath-92
Copy link
Collaborator

This is a bummer. Presumably the last version, which did some major refactoring introduced a bug. I will invest some time looking at some Linux I have available to see what's happening. Unfortunately I don't have any access to a Mac so that's a bit difficult for me to fix, we can only hope that the issues on Linux are the same as the Mac ones 😅
Otherwise, @stevensona do you have the possibility to look into this on Mac OS?

@Malacath-92
Copy link
Collaborator

I think the issue is only a path issue that we didn't handle correctly. If you have a chance to test #46 it would be greatly appreciated. I tested on Ubuntu 18.10, though didn't have WebGL available. But it seemed the core issue, which was that the WebView wasn't able to load resources, is fixed at least on Linux systems, presumably also on MacOS.

@Malacath-92
Copy link
Collaborator

@ianacaburian This change is now live, let us know if it is fixed now or not.

@ianacaburian
Copy link
Author

Hey guys, I tested the new version 0.82 and still had the same problem. So I thought I'll try updating VS Code. It was already up to date but it gave me a message "Unable to perform update on read-only volume." My app was still located in a folder other than Applications. After moving VS Code to Applications, the extension works fine now. So a bit inconclusive as to whether the new commits fixed anything but there you go.

@Malacath-92
Copy link
Collaborator

Interesting 😄
Can some one else see if the issue is fixed with the newest version?
@uniformfake @edap @nickkuk

@nickkuk
Copy link

nickkuk commented Apr 8, 2019

@Malacath-92, thanks! Shader works now, but textures don't load, and there is no warnings.
I tried both

#iChannel0 file://./texture.png

and .vscode/settings.json with

{
  "shader-toy.textures": {
    "0": "file://./texture.png",
  }
}

@Malacath-92
Copy link
Collaborator

It looks like I have some commits that didn't make it into the PR and should fix this. I'll make a new PR as soon as I get home.

@nickkuk
Copy link

nickkuk commented Apr 11, 2019

@Malacath-92, textures work in 0.8.3 now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants