Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is it possible to support glslify in this great package? #64

Closed
shengsword opened this issue Jul 7, 2019 · 3 comments · Fixed by #68
Closed

is it possible to support glslify in this great package? #64

shengsword opened this issue Jul 7, 2019 · 3 comments · Fixed by #68
Assignees
@Malacath-92
Labels
enhancement

Comments

@shengsword
Copy link

No description provided.

@shengsword shengsword changed the title is it possible to support glslify in this greate package? is it possible to support glslify in this great package? Jul 7, 2019
@Malacath-92 Malacath-92 self-assigned this Jul 7, 2019
@Malacath-92
Copy link
Collaborator

Looks feasible, I will take a look at it as soon as I can.

@Malacath-92
Copy link
Collaborator

Looks like supporting it is quite simple, however it doesn't support mapping lines from post-transform to pre-transform. So I'll disable it by default and remove any of the line information from the error output if it is enabled, which is a shame. I'll consider opening an issue on the glslify page in the future.

@shengsword
Copy link
Author

Wow, it still be very useful if glslify is working in shader-toy though a little deficiency there

@Malacath-92 Malacath-92 mentioned this issue Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Malacath-92 Malacath-92

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Texture settings, Malacath-92/shader-toy
2 participants
@Malacath-92 @shengsword