-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose default timeouts to public #59
Comments
By the way it would be also helpful to have some clean method after usage of What do you think? |
I think TimeoutConfiguration::default() could be used as the default (both internally and also people can use it to infer the defaults later if needed). As I've said before, the plan with |
I think I may have misunderstood your later comment. Were you thinking that |
I've implemented However if we want to allow the configuration to be updated at any time, then I would suggest putting the entire WebDriverSession inside a mutex i.e. |
I was just thinking that things we need to set up to use a thirtyfour_query and to switch to default behavior could be hidden by some functions. But never mind 😉 don't worry to much about it |
Regarding removing boilerplate from the This means you can now use I suspect the existence of I haven't published v0.25 yet. |
looking forward 0.25 :) |
Hi @stevepryde what do you thing to make a public constant or exposed method for a default
TimeoutConfiguration
?It would be useful to be able to obtain a default one to be able to switch back after a usage of
thirtyfour_query
andset_implicit_wait_timeout
thirtyfour/src/webdrivercommands.rs
Lines 78 to 83 in 83c91ce
The text was updated successfully, but these errors were encountered: