Refactor Range and Diet to generate values lazily #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stew
commented
Nov 18, 2016
stew
commented
many of the operations in Range and Diet relied on eagerly generating exhaustinve lists of elements. This commit refactors those to evaluate their contents lazily, which should have a dramatic reduction of the amount of garbage generated.
Current coverage is 46.28% (diff: 67.70%)@@ master #74 diff @@
==========================================
Files 20 20
Lines 1707 1642 -65
Methods 1429 1400 -29
Messages 0 0
Branches 278 242 -36
==========================================
- Hits 849 760 -89
- Misses 858 882 +24
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.