Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

xLabelAngle #49

Closed
dAnK3L opened this issue Apr 6, 2016 · 13 comments
Closed

xLabelAngle #49

dAnK3L opened this issue Apr 6, 2016 · 13 comments

Comments

@dAnK3L
Copy link

dAnK3L commented Apr 6, 2016

Hi, i am trying to apply xLabelAngle on my bar chart which doesnt seem to work

bar-xLabelAngle=10

any help would be apprieciated.

@loren138
Copy link
Contributor

loren138 commented Apr 6, 2016

After #50 is merged and you update, you'll be able to use this with bar-x-label-angle="'90'".

@dAnK3L
Copy link
Author

dAnK3L commented Apr 7, 2016

This doesnt seem to work what could i be missing?

@dAnK3L
Copy link
Author

dAnK3L commented Apr 7, 2016

bar-chart
bar-data="debtOverview"
bar-x="DueDate"
bar-x-label-angle="'50'"
bar-y='["TyDecimal"]'
bar-labels='["TY"]'
bar-colors='["#1a96b4"]'
bar-resize="true"
bar-hide-hover="'auto'">

@stewones
Copy link
Owner

stewones commented Apr 7, 2016

Hi @dAnK3L

it would be more easier to help if you try to reproduce your issue in tools like jsfidle.net and then share here

you can start by forking this sample and modifying it for your use case

@dAnK3L
Copy link
Author

dAnK3L commented Apr 7, 2016

Hi, i have updated the fiddle wth what i have with static data and the label doesn change angle..

https://jsfiddle.net/66hwn6tv/

@loren138
Copy link
Contributor

loren138 commented Apr 7, 2016

It won't work until the pull request I tagged is merged because it isn't currently supported by this plugin. It looks like I made a mistake in my request though and I'm sick today so I can't go in to fix it. I should have time next Tuesday.

@dAnK3L
Copy link
Author

dAnK3L commented Apr 11, 2016

do you think this will be done soon? its really urgent for me

@loren138
Copy link
Contributor

I'll be back at work tomorrow. If you're using a js file, you could always temporarily use the version from #50.

@stewones
Copy link
Owner

this feature is already implemented on master

https://github.com/stewones/angular-morris-chart/search?utf8=%E2%9C%93&q=xLabelAngle

@stewones
Copy link
Owner

@dAnK3L

checkout this sample https://jsfiddle.net/stewones/8apkc98c/

I'll close but feel free to reopen or ask anything

@loren138
Copy link
Contributor

This is a bar chart, it is implemented on line and area, but not bar. (The sample is a line chart, hence why it works there.)

See: https://github.com/stewones/angular-morris-chart/search?utf8=%E2%9C%93&q=xLabelAngle

You'll notice it shows in areaChart.directive.js and lineChart.directive.js but not barChart.directive.js hence why pull request #50 is necessary to add it to barChart.directive.js.

See https://github.com/stewones/angular-morris-chart/pull/50/files#diff-5a33a6be0ad0f71f5b129dd895b88488R41 for the line change adding it to barChart.directive.js.

As mentioned above, I'll update my pull request to remove duplicate items tomorrow so it can be merged.

@stewones
Copy link
Owner

@loren138 👍

@stewones
Copy link
Owner

fixed by #50
thx @loren138

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants