Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect format type for barActiveThumbColor attribute #7

Closed
stephen-rival opened this issue Sep 18, 2019 · 2 comments
Closed

Incorrect format type for barActiveThumbColor attribute #7

stephen-rival opened this issue Sep 18, 2019 · 2 comments

Comments

@stephen-rival
Copy link

The attribute for barActiveThumbColor is defined as:
<attr name="barActiveThumbColor" format="dimension" />

When it is read in by the View, it is done so like this:

 thumbActiveColor = typedArray.getColor(
            R.styleable.PriceRangeBar_barActiveThumbColor,
            thumbActiveColor
        )

I believe the attribute should be defined as:
<attr name="barActiveThumbColor" format="color" />

@andriizhumela
Copy link
Collaborator

Hi @stephen-rival !
You're right. It will be fixed in next version.

@andriizhumela
Copy link
Collaborator

@stephen-rival fixed in version 0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants