Sync Fork from Upstream Repo #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the meta-grammar generator to account for "cal" module correctly.
Update the SDL overview documentaiton to indicate that the SDL describes the schema as a whole as opposed to a single module. Add a section to describe SDL module blocks. Update migration docs and remove DDL migrations as we have tested the SDL migrations only. Make doc tests aware that SDL may or may not contain a module block and thus require slightly different handling of the syntax test. Fixes: #974.
Currently, the order of processing of `CreateObject` subtrees is rather awkward. The generic implementation simply iterates over referenced object subcommands, and various schema classes tack on their own hacks to implement inheritance propagation etc. On top of that, handling of anonymous derived objects, like unions and collection types is hacky and buggy as well. To fix this, make the generic `CreateObject.apply` truly generic, which makes it behave like `AlterObject.apply` already does. This necessiated the addition of a concept of "prerequisites" for a command, i.e. subcommands that must run before the object itself is created.
All concrete links have a placeholder for the module name, make sure it does not show up in introspection queries. Fixes: #995.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.