Sync Fork from Upstream Repo #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the necessary infrastructure for global objects that is used by Roles, so make Database objects benefit from that as well. There is a small caveat: `CREATE DATABASE` and `DROP DATABASE` are non-transactional, so add facilities to ensure that these statements don't get wrapped into a transaction.
* Stop reassigning ownership from the connecting user * Fix `\psql` in REPL * Make sure the bootstrapping user is a member of the role with initial authorization. * Disable use of 'C.UTF-8' on RDS.
This development tool allows removing all traces of EdgeDB from the specified PostgreSQL cluster. Useful for cases when debugging bootstrap and setting up new clusters is expensive.
Constraints are overloaded callables, and so require that the arguments of a constraint are specified when doing `ALTER` or `DROP`. Issue: #1134.
Currently we don't distinguish between limited and unlimited precision/size numbers in GraphQL. Which means that by default it makes sense to treat `Int` as `bigint` and `Float` as `decimal` (especially for variables). This preserves the precision when it's needed and can be downcast to the specific type the expression requires. Since `int64` is implicitly castable into `bigint` it's possible to treat small `Int` literals as `int64` and large ones as `bigint`. Stop mapping `bigint` onto `Float` and use `Int` instead. This technically breaks the sprict spec for `Int` and `Float`. Introducing custom types would be a separate PR. Issue #1138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.