Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default_case option for Response plug #3

Closed
wants to merge 2 commits into from
Closed

Added default_case option for Response plug #3

wants to merge 2 commits into from

Conversation

madshargreave
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Sep 1, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 96.364% when pulling e319820 on madshargreave:default-case into 945659b on sticksnleaves:master.

@coveralls
Copy link

coveralls commented Sep 1, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 96.364% when pulling e319820 on madshargreave:default-case into 945659b on sticksnleaves:master.

@madshargreave madshargreave mentioned this pull request Sep 4, 2017
Closed
@anthonator
Copy link
Contributor

Thanks for putting this together! Sorry for not getting back to this sooner. Had a short week last week.

What if someone passes in an unsupported case? Should the default case be used?

@tf
Copy link

tf commented Sep 29, 2017

I also think falling back to the default in unsupported cases would make sense.

@anthonator
Copy link
Contributor

@madshargreave could you implement a fallback to :default_case in the event an unsupported case is provided?

@anthonator
Copy link
Contributor

Closing due to inactivity.

@anthonator anthonator closed this Aug 31, 2018
@iceniveth iceniveth mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@madshargreave @coveralls @anthonator @tf