-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adding CLI functionality and Pre-Commit hook #62
Open
stiebels
wants to merge
36
commits into
main
Choose a base branch
from
feat-precommit-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 99.53% 99.56% +0.02%
==========================================
Files 4 5 +1
Lines 428 456 +28
==========================================
+ Hits 426 454 +28
Misses 2 2 ☔ View full report in Codecov by Sentry. |
stiebels
changed the title
WIP: CLI functionality and precommit hook
Feature: Adding CLI functionality and Pre-Commit hook
Oct 28, 2023
…ightline into feat-precommit-hook
stiebels
added
python
Pull requests that update Python code
github_actions
Pull requests that update GitHub Actions code
labels
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
github_actions
Pull requests that update GitHub Actions code
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Proposed Changes
This change introduces
sagemaker-rightline
console scriptpre-commit
hook running the CLI scriptConsole Script
The console script accepts a path to a
py
file that holds aget_configuration
function. This function is expected to return asagemaker_rightline.model.Configuration
object. The configuration is then run and exits with0
if all containedValidation
objects showsuccess=True
and exits with1
if at least one showssuccess=False
.Example usage:
General example:
Try it out in the context of the
sagemaker-rightline
project example:Pre-Commit hook
The pre-commit hook
sagemaker-rightline
runs the CLI script to validate yourConfiguration
atgit commit
. Never commit a faulty pipeline again!Using the pre-commit hook
ToDo's
Maintenance