Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the lookup of attribute of the Pipeline object #6

Open
stiebels opened this issue May 24, 2023 · 0 comments
Open

Redesign the lookup of attribute of the Pipeline object #6

stiebels opened this issue May 24, 2023 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers

Comments

@stiebels
Copy link
Owner

stiebels commented May 24, 2023

Problem Statement
The general path parsing, attribute lookup and filter functionality is convoluted and requires re-design:

Target State
The overall objective is to make the implementation of new Validations as easy as possible by providing developers and users a robust and general functionality to search and filter for the desired attribute (value).

More concretely:

  • Generalized lookup functionality that can be used across Validations to find appropriate attributes of any object.
  • Should allow for filtering based on user input:
    • indices, e.g. if an attribute is a list and the user wants to fetch the first item of that attribute/list
    • value of attributes, e.g. if an attribute is a dict or other complex object
@stiebels stiebels added invalid This doesn't seem right feature New feature or request and removed invalid This doesn't seem right labels May 24, 2023
@stiebels stiebels changed the title Refactor sections marked with # TODO: refactor Redesign the attribute lookup in the Pipeline object Jun 1, 2023
@stiebels stiebels changed the title Redesign the attribute lookup in the Pipeline object Redesign the lookup of attribute of the Pipeline object Jun 1, 2023
@stiebels stiebels added the good first issue Good for newcomers label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant