Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should exception_t::raise receive error_descr as string_view instead of std::string? #46

Closed
eao197 opened this issue May 31, 2022 · 1 comment
Assignees
Milestone

Comments

@eao197
Copy link
Member

eao197 commented May 31, 2022

Here:

exception_t::raise(
const char * file_name,
unsigned int line_number,
const std::string & error_descr,
int error_code )

It seems that so_5::exception_t::raise can receive std::string_view instead of std::string.

@eao197 eao197 self-assigned this May 31, 2022
@eao197 eao197 added this to the SO-5.8.0 milestone Feb 13, 2023
@eao197
Copy link
Member Author

eao197 commented Apr 5, 2023

Will be a part of 5.8.0 release.

@eao197 eao197 closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant