Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement offset line #2

Closed
stijnwop opened this issue Jan 28, 2019 · 21 comments
Closed

Implement offset line #2

stijnwop opened this issue Jan 28, 2019 · 21 comments
Assignees

Comments

@stijnwop
Copy link
Owner

No description provided.

@stijnwop stijnwop self-assigned this Feb 1, 2019
@stijnwop stijnwop added the enhancement New feature or request label Feb 1, 2019
@stijnwop stijnwop added this to To do in Guidance Steering Feb 3, 2019
stijnwop added a commit that referenced this issue Feb 28, 2019
@stijnwop
Copy link
Owner Author

Implement, please test.

@stijnwop stijnwop added the fixed label Feb 28, 2019
@KITT3000
Copy link
Contributor

KITT3000 commented Mar 1, 2019

The offset can only be set in 1 direction.
Would it be possible to add a value change using the mouse wheel (eg after hovering the window with the value)?

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 1, 2019

Explain? You can set the incremental on negative so it flips the side.

@dehjvg
Copy link

dehjvg commented Mar 1, 2019

wat he means (i think)

is when your plowing with a plow that can rotate you want the ofset to change side as well.

so lets says you set a positive ofset of 1.0 but when your on the end of the field you turn the plow and tractor then you need a negative ofset of 1.0

video exemple of the fs 17 gps https://youtu.be/xuY8eutbcAg?t=429
(there the ofset did automaticly change when you turned around the tractor)

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 1, 2019

Ah yea, it tried to fix that last night because it's also inverting when you drive backwards that way. Need to have something depending on drive direction I guess. Will fix.

@KITT3000
Copy link
Contributor

KITT3000 commented Mar 1, 2019

How can I set a negative offset since the button increases the value always on the positive?

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 1, 2019

In the second column you have a selection box where you can select the increment.. from 0.01, 0.1, 0.5 etc to -0.01, -0.1, -0.5 etc.

If you select the increment there and hit the offset button it will either go negative or positive depending on the increment you've set earlier.

@KITT3000
Copy link
Contributor

KITT3000 commented Mar 1, 2019

ok, a bit strange system (I do not know what relationship has an additional change in working width with offset)

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 1, 2019

What are you trying to say between the ()?

The incremental has no relationship with width or offset it just defines how much you can incremental a given value.. how hard can that be? If you want fine steps you have a small incremental number else you select a bigger one. What that number you can update the offset or width.

@KITT3000
Copy link
Contributor

KITT3000 commented Mar 1, 2019

Now I've got how it works, only the field "Width increment" is very confusing (as if it only served to change the width, in addition it was before the appearance of the offset). This field is best if it had a changed name, e.g. "Change in value by" and moved to column 1, so that it would not be associated only with the working width.

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 1, 2019

Yes good suggestion, will change the name of the increment.. it's misleading indeed. 👍

@dehjvg
Copy link

dehjvg commented Mar 1, 2019

just noticed its not working on dedicated multiplayer server.

you can set but it keeps going on the centerd line and not on the ofset line
(did test on singel player and there it works as intended)

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 2, 2019

Should work now. @dehjvg

stijnwop added a commit that referenced this issue Mar 2, 2019
@dehjvg
Copy link

dehjvg commented Mar 2, 2019

@stijnwop its fixed for 50% positive ofset is working but negative ofset is not following any gps line far as i can see

stijnwop added a commit that referenced this issue Mar 2, 2019
@stijnwop
Copy link
Owner Author

stijnwop commented Mar 2, 2019

@dehjvg Alright thats suppose to be fixed too.. ;)

@dehjvg
Copy link

dehjvg commented Mar 2, 2019

still the same isseu did not change

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 2, 2019

Explain your issue with images etc.. cause this isn't working.

@KITT3000
Copy link
Contributor

KITT3000 commented Mar 2, 2019

btw. only me don't show a tip from the offset?

@dehjvg
Copy link

dehjvg commented Mar 2, 2019

https://www.youtube.com/watch?v=JSQltFi4tTY&feature=youtu.be hope this helps

but when i set ofset 1 it follows the ofset line when -2 it goes to the rightr but not following the gps
(its on dedicated server)

@stijnwop
Copy link
Owner Author

stijnwop commented Mar 2, 2019

@dehjvg thanks for the video!
Fixed the bug.

@dehjvg
Copy link

dehjvg commented Mar 2, 2019

@stijnwop i can comfirm its working good now :D

stijnwop added a commit that referenced this issue Mar 2, 2019
@stijnwop stijnwop moved this from To do to In progress in Guidance Steering Mar 2, 2019
@stijnwop stijnwop moved this from In progress to Done in Guidance Steering Mar 2, 2019
stijnwop pushed a commit that referenced this issue Mar 2, 2019
Implemented offset line. (#2)
@stijnwop stijnwop closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants