Make it easy to find out "which response is which"

[stil]

It's a very popular problem - how to know which response is which. They may appear in random order, so we need to add a feature allowing to associate responses with their starting parameters.

[tonivdv]

Hey @stil ,

Can you share a specific use case? I guess today you could simple build this in your application logic?!

[stil]

An use case could be for example fetching list of paginated offers from online shopping website. You would make 10 requests to download first 10 pages of offers.

http://www.morele.net/komputery/sieci/routery-48/0,0,,,,,,,,,/1/
http://www.morele.net/komputery/sieci/routery-48/0,0,,,,,,,,,/2/
http://www.morele.net/komputery/sieci/routery-48/0,0,,,,,,,,,/3/
...

Then you send requests in parallel. Responses may appear in different order, and you wouldn't know which page you have just fetched.

Currently there are two ways to associate responses:

• Set dynamic attribute to Request object, for example:

$i = 1;
$request = new \cURL\Request("http://www.morele.net/komputery/sieci/routery-48/0,0,,,,,,,,,/$i/");
$request->_page = $i;

• Create a requests map with request object hash as keys and request context (ie. page number) as value.

First approach is unelegant and some IDEs will complain about setting dynamic attributes. And second requires a few additional lines of code.
I think I'm going just add setContext() method to Request class which would accept mixed values, so you can store custom information about this request.

Or, in more object oriented way: setContext() would accept RequestContextInterface. Then you would need to derive your class from this interface.

[tonivdv]

Ok I see. Thanks for the detailed response.

Your third solution seems most appropriate. Especially with interface implementation, because it allows freedom to the user to implement whatever he wants it for.

Not sure about the setContext naming though. That being said I don't have any alternatives to share.

[wozzup]

stil commented 2 days ago
I think I'm going just add setContext() method to Request class which would accept mixed values, so you can store custom information about this request.
Or, in more object oriented way: setContext() would accept RequestContextInterface. Then you would need to derive your class from this interface.

awesome! can't wait

[wozzup]

$request->_page = $i;

worked for me, in the

$queue->addListener('complete', function (\cURL\Event $event)
{
    var_dump($event->request->_page);
}

thanks stil