Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddCommand don't add autocompletion all the times #14

Open
Wokarol opened this issue Oct 24, 2018 · 3 comments
Open

AddCommand don't add autocompletion all the times #14

Wokarol opened this issue Oct 24, 2018 · 3 comments

Comments

@Wokarol
Copy link

Wokarol commented Oct 24, 2018

When I'm adding command at runtime using AddCommand, autocompletion word for this command isn't always added. I don't know why.

@Wokarol
Copy link
Author

Wokarol commented Oct 25, 2018

I've done some testing and looks like AddCommand automatically adds word for autocompletion in editor, but doesn't do this on standalone build. So code that I have to do for it to works looks like that:

Terminal.Shell.AddCommand(
   commandName
     .Replace("{name}", name)
     .Replace("{parent_name}", (transform.parent != null) ? transform.parent.name : name),
     Execute, 0, 0, help);

#if !UNITY_EDITOR
Terminal.Autocomplete.Register(
   commandName
     .Replace("{name}", name)
     .Replace("{parent_name}", (transform.parent != null) ? transform.parent.name : name)
     ); 
#endif

@Wokarol Wokarol closed this as completed Oct 26, 2018
@Wokarol Wokarol reopened this Oct 26, 2018
@stillwwater
Copy link
Owner

stillwwater commented Oct 29, 2018

Could this be related to script execution order? All registered commands get added to autocomplete during the Start procedure in Terminal.cs.

Edit: I'll try to find a workaround for this, maybe a refresh_autocomplete command to add any commands that were left out. Or perhaps having the interpreter raise an event whenever a new command is added, allowing the autocomplete to use the events to add commands as soon as they registered.

@Wokarol
Copy link
Author

Wokarol commented Oct 29, 2018

I've done some testing. I'm using persistent scene in my project and looks like loading scene with Terminal as second one screws few things up. I've exposed some things and created this script:
https://pastebin.com/8MQ7rR8i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants