-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make placeholder block optional #76
Comments
I'm starting to wonder if that's maybe a special case for I think it could be sufficient to make the placeholder optional when eager is |
My intended use case is for rendering actions or buttons that are dependant on a users permission levels. hacked together example is at https://sleepy-sea-13861.herokuapp.com/?showAll=true In my case, I really don't want a spinner or anything to indicate that it's loading, but the button can pop in when it's returned from the server. I think you're right that I may make it |
Why what is required? The placeholder? Because something needs to trigger the intersectionobserver. But eager: true short circuits that anyway, so maybe we can make the placeholder optional if eager is true? |
Yeah, I think I understand the technical reasons why a placeholder is needed, but what I don't understand is why it needs to be user-provided. Can the placeholder default to something like |
Ah I see! Well yes and no, it can be a default but it needs to be actually visible. |
Maybe we could make everything a bit simpler and say, if no placeholder, make it an eager element. Could deprecate eager in the future... |
Feature Request
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: