Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'getValue') #210

Open
bilalkocak opened this issue Apr 13, 2022 · 34 comments
Open

Comments

@bilalkocak
Copy link

bilalkocak commented Apr 13, 2022

I'm using your great module on my all projects but i couldn't implement to new one.

I got this error when "open state" to true. -> "TypeError: Cannot read properties of undefined (reading 'getValue')"

my dependencies:
"react-spring-bottom-sheet": "^3.4.0",
"next": "12.1.4",
"react-dom": "18.0.0",

Code:

 const [open, setOpen] = useState(false)
    return (
        <>
            <button onClick={() => setOpen(true)}>Open</button>
            <BottomSheet open={open}>My awesome content here</BottomSheet>
        </>
    )

image

@howlettt
Copy link

Ran into the same issue, looks like it's a issue with React v18 StrictMode, removing StrictMode or running a prod build it works fine.
https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors

@howlettt
Copy link

Looks like react-spring doesn't support React v18 yet
pmndrs/react-spring#1563

@joshuaellis
Copy link

I've launched a beta for react18 that should resolve issues and be good to go – 9.4.5-beta.1 please feel free to give it a go and any issue feedback on that issue you linked too :)

@ivanoliveiraitez
Copy link

How i do access the beta version?

@alexchavero
Copy link

I would like to try the beta also, where can I download it? thanks

@joshuaellis
Copy link

joshuaellis commented May 19, 2022

I actually launched a new version of react-spring that works with r18, so I think this project would need to update its deps accordingly 👌🏻 9.4.5 for reference.

@alexchavero
Copy link

alexchavero commented May 19, 2022

Thanks joshuaellis, I uninstalled the react-spring-bottom-sheet package and re-installed it. Then checked the react-spring version and is now the 9.4.5 you mentioned; but I still getting the same error: TypeError: Cannot read properties of undefined (reading 'getValue'). The error is in the localhost only, in production works fine.

Did I missed something else that you can help me please?

@joshuaellis
Copy link

Well the package here is locked to version 8 API, so it probably needs a good update to be working with react18 & react-spring9

Id try talk to the maintainer or update the lib and submit a PR.

@maxizhukov
Copy link

Have same while migrated from react to nextjs, react 18.2.0, but was working fine with 17

@AshMW2724
Copy link

@joshuaellis I have gone ahead and made the changes needed to upgrade to react-spring v9.4.5

@SebastienSusini
Copy link

I still have the issue with the last version, any ideas ?

@klanthier
Copy link

klanthier commented Jul 14, 2022

Same here, latest version (3.4.1) on react 18 still triggers the same issue.
Running on NextJS if that helps

@treyhuffine
Copy link

I'm having the same issue as well. Let me know if there is anything I can do to help resolve it.

@OskarD
Copy link

OskarD commented Aug 16, 2022

It seems to be working in 3.5.0-alpha.0

@odafeaggreh
Copy link

Please has a solution to this been discovered? I'm having the same issue now

@mard0n
Copy link

mard0n commented Oct 17, 2022

the issue is still there
"react": "^18.2.0", "react-dom": "^18.2.0", "react-spring-bottom-sheet": "3.5.0-alpha.0"

@novaladip
Copy link

the issue is still there "react": "^18.2.0", "react-dom": "^18.2.0", "react-spring-bottom-sheet": "3.5.0-alpha.0"

it's working fine on me, maybe try to remove the node_modules folder then run npm install again?

my package.json
"react": "18.2.0",
"react-dom": "18.2.0",
"react-spring-bottom-sheet": "3.5.0-alpha.0",

@nazaninroozbahani
Copy link

I have the same issue. It's also working in version 3.5.0-alpha.0.
Why not release the original version?

@unmanned-harry
Copy link

Same issue here

@precz
Copy link

precz commented Dec 17, 2022

🆙

@nadiannis
Copy link

I got the same problem.

My dependencies:

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-spring-bottom-sheet": "^3.4.1"

@ramirez411
Copy link

ramirez411 commented Mar 7, 2023

I got the same error with:

"react": "18.2.0",
"react-dom": "18.2.0",
"react-spring-bottom-sheet": "^3.4.1".

I am looking for other options to do the same, instead I´ll try to use this: https://www.npmjs.com/package/react-modal-sheet

I would appreciate if other people have more options.

@howlettt
Copy link

howlettt commented Mar 8, 2023

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

@ramirez411
Copy link

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Thanks

@joaolfern
Copy link

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Very nice animations, but I unfortunately couldn't figure out how to use it with JSX

@kiki-le-singe
Copy link

I would like to use this package, but unfortunately it doesn’t work...

"next": "13.4.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-spring-bottom-sheet": "^3.4.1" | "3.5.0-alpha.0" 

@AyushSaini00
Copy link

it worked by disabling the react strict mode on nextjs 13.

@howlettt
Copy link

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Very nice animations, but I unfortunately couldn't figure out how to use it with JSX

tech-systems/panes#142 (comment)

@kthehatter
Copy link

i guess still no solution for this issue i'm having this issue as well on nextjs 13

@Franjoo
Copy link

Franjoo commented Nov 8, 2023

⬆️ Same issue here, any updates on that?

@dong-nguyen
Copy link

I still facing this issue when upgrading to Next.js 14. it works fine on Next.js 13.4 before.

@qasimgit
Copy link

qasimgit commented Feb 9, 2024

Same here, getting this error in Next 14, has anyone found any solution?

@lucasromerodb
Copy link

It seems to be working in 3.5.0-alpha.0

Be careful with 3.5.0-alpha.0 version, it installs a lot of new dependencies who has at least 5 high vulnerabilities that allows SSRF attacks. Learn more here

@Stokel
Copy link

Stokel commented Apr 16, 2024

3.5.0-alpha.0 gets rid of the error for me but introduces scrolling bugs on mobile iOS. The first touch/scroll is always way too fast. Anyone has the same problems and a workaround for this?

It also introduces a bug which closes the bottom sheet for us during scrolling a long list before reaching the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.