Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] metasrc runes not working #79

Open
aleeperezz16 opened this issue Jan 7, 2022 · 3 comments
Open

[Bug] metasrc runes not working #79

aleeperezz16 opened this issue Jan 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@aleeperezz16
Copy link

aleeperezz16 commented Jan 7, 2022

Selecting use Metasrc.com runes doesn't load them

  • OS: Windows 11
  • RuneChanger Version [1.14.3]

I've tried using also the experimental version and still happens

@stirante stirante added the bug Something isn't working label Jan 7, 2022
@stirante stirante self-assigned this Jan 7, 2022
@SoloFausto
Copy link

I think that the problem is that the program is trying to access a url with the first letter of the champion name in uppercase (is trying to go to https://www.metasrc.com/5v5/champion/Zed/ instead of https://www.metasrc.com/5v5/champion/zed/) and when that happens it creates an exception, digging around in the source code i thing that the problem is located in the MetasrcSource.java in line 46

@stirante
Copy link
Owner

stirante commented Mar 1, 2022

I thought so too, but after fixing it locally, it turns out they changed the site layout as well, so the source needs to be changed as well to match that.

@SoloFausto
Copy link

Thats bad, good luck too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants