Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template not extending bootstrap but override it #36

Closed
pradosh987 opened this issue Mar 12, 2019 · 2 comments
Closed

Template not extending bootstrap but override it #36

pradosh987 opened this issue Mar 12, 2019 · 2 comments

Comments

@pradosh987
Copy link

Is there any specific reason why this template is overriding bootstrap 4 css and not extending it using scss? I mean overriding is ok but extending with scss gives more flexibility and simplicity.

@nauvalazhar
Copy link
Member

You could be right. But, I see another view, that by overriding Bootstrap it will be easier to update, I can use CDN, I don't "touch" their code or anything else. I position Bootstrap as a framework, not as a UI kit (although they provide pre-designed components). I only need Bootstrap for layout, component base, etc. That way, I just need to override their style, no need to create it from scratch, and when there is an update it will be easy to update.

In short, I don't want to "touch" the Bootstrap code for ease of life 😆

@pradosh987
Copy link
Author

Bootstrap has been very stable in its release cycle and breaking changes has only been in major version release so its pretty safe to extend it. I find this approach difficult to reason with simply because its to have consistency with bootstrap framework.

Anyways your theme looks good. Keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants