Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type assistance for non system-ui properties #4

Closed
CodingDive opened this issue Apr 17, 2020 · 2 comments
Closed

Type assistance for non system-ui properties #4

CodingDive opened this issue Apr 17, 2020 · 2 comments

Comments

@CodingDive
Copy link
Contributor

The type support seems great for the system-ui properties that we are configuring ourselves. Is there a way to achieve the same thing for display, alignItems and all the other css properties?

image
@CodingDive CodingDive mentioned this issue Apr 18, 2020
Closed
@christianalfoni
Copy link
Contributor

Hi @CodingDive !

I did some research on this, it is actually how Typescript works, which is sad and we should find a workaround. Here is the thread: microsoft/TypeScript#29729 (comment)

It is really weird though, cause I did have the types at some point.... hm.

Though to improve typing speed I am considering just running our own typing for CSS

@christianalfoni
Copy link
Contributor

Okay, so I think we just need to follow up on this ourselves, I changed the typing so we get full control. Fixed in new release coming now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christianalfoni @CodingDive