Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract client configuration to separate structure #9

Closed
stklcode opened this issue May 9, 2020 · 1 comment
Closed

extract client configuration to separate structure #9

stklcode opened this issue May 9, 2020 · 1 comment
Assignees
Milestone

Comments

@stklcode
Copy link
Owner

stklcode commented May 9, 2020

The only coonfiguration available up to 1.3 is the API base URL and optionally custom paths to instant and stream endpoint.

Introduce a dedicated configuration structure and corresponding builder to make the configuration more speaking, reusable and easily extensible.

@stklcode stklcode added this to the 2.0 milestone May 9, 2020
@stklcode stklcode self-assigned this May 9, 2020
@stklcode
Copy link
Owner Author

stklcode commented May 9, 2020

In 84f0066 a new class has been introduced: UraClientConfiguration and the initialization pattern has been refactored to something like

UraClient client = new UraClient(
    UraClientConfiguration.forBaseurl("...")
                          .withInstantPath("...")
                          .withStreamPath("...")
                          .build()
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant