Fixes Unexpectedly Found Nil When Unwrapping Optional in WebAuthenticationPresenter #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added #available wrapper for ASPresentationAnchor.
ericlewis
approved these changes
Sep 23, 2021
stleamist
requested changes
Sep 25, 2021
Sources/BetterSafariView/WebAuthenticationSession/WebAuthenticationPresenter.swift
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Sep 25, 2021
|
Please merge this fix! |
…ationPresenter.swift Co-authored-by: Dongkyu Kim (Max) <stleamist@me.com>
|
Great! I really appreciate your work on fixing this issue! This improvement will be available in v2.4.1 shortly :) |
This was referenced Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the unexpectedly found nil when unwrapping optional by using ASPresentationAnchor() for iOS 13+ and MacOS 10.15+, otherwise defaults to original behavior.