-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dumb query #36
Comments
@calo1, I think I solved the SQL join issue. More updates to come, but it seems that I found a way to do joins. Minor issues and details related to it:
|
Currently, parcel-only queries and survey-only queries are working like a charm with join operations across the layers. A semantic issue, I believe not technical, is that queries that involve both parcel and survey data (queries where all the three tables are involved) will hardly display results due to sparseness of the dataset; the more filters applied, the less results displayed. Do we want to somehow apply "union" for this type of queries, in order to increase the chance that we see some results (this might also help development and debugging process)? If we do, how? I'm still working on this type of queries, but I want to make sure how we want to deal with it. @calo1, what do you think? |
I pushed my updates and deployed the latest version to the production sever. Good to see the app with the fully functioning query feature. I'll keep this issue open for a few days so that @calo1 can test it. Any comments are welcomed. |
Just note that the map lost interactivity of infowindow becuase the app doesn't import vizjson data from Carto. I'll create another issue on getting back the basic on-map interactivity. |
@stlim0730 Query works well, I tested it sufficiently. That is a big milestone! But I'm a little worried about how to manage changes in map styling and data ... If I make new layers or new CartoDB visualizations ... How will the application reflect the changes? The vizjson was the Adam-proof way of getting those styling in the app. I have CartoCSS files for each layer. Should I drop them here? |
@calo1, good point. The settings are hard-coded in the source for now. The settings can be (and must be) modeled and configured on the admin panel later. This will be everyone-proof way. I think you should copy and paste some settings and code snippets from Carto (there's no CartoDB now!) to the admin panel, at most. Or, if I can come up with good enough design within the code, the copy and paste might not be even needed. We'll found out what we want to configure or not. Showing a warning message is a good idea that also addresses other general needs, such as Carto errors. I'll work on it with low-to-med priority on on-map-interaction branch. Did you notice the basemap changed? Take a look at Mapbox (https://www.mapbox.com) and let me know your preferred map tile. Map tile configuration will be also part of the admin configuration later. Map interactivity: One minor error I found was that the app fails to query the unique |
@stlim0730 Also: A general goal is that Farmview can be a suit of tools to replicate in other agricultural counties. Severing the link to 'carto' means that technical expertise will be needed as more visualizations are changed or added. |
@calo1, I understand your concern. Let me try to find the optimal way that doesn't really compromise the accessibility through Carto. Improving Django admin panel's usability might be an option. |
@stlim0730 small note: The legend is also defined with html via Carto |
Now query works fine, so I'm closing this issue. |
Even though we need to find a good way to smoothly join the three data tables on-the-fly, the basic query features should work.
This issue includes debugging query feature for survey data (currently broken) and finding a reasonable way to present query results without join operations.
I'm assigning myself to this issue.
The text was updated successfully, but these errors were encountered: