Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update for CI integration #1118

Closed
6 tasks done
Nightwalker-87 opened this issue Mar 27, 2021 · 4 comments
Closed
6 tasks done

[feature] Update for CI integration #1118

Nightwalker-87 opened this issue Mar 27, 2021 · 4 comments

Comments

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Mar 27, 2021

Thank you for giving feedback to the stlink project.

NOTICE: Please read and follow instructions in #906 before submitting a ticket.
This feature request will be deleted without notice when not enough information is provided! So please ensure that all fields are filled out.

  • I made serious effort to avoid creating duplicate or nearly similar issue

In order to allow developers and other contributors to isolate and target your respective issue, please take some time to select the check boxes below and fill out each of the following items appropriate to your specific request.

  • Programmer/board type: [N/A] (e.g STLINK /V1, /V2, /V2-onboard, /V2-clone, /V3)
  • Operating system an version: [Linux, macOS] (e.g Linux, macOS, Windows)
  • stlink tools version and/or git commit hash: [v1.6.1+] (e.g v1.6.1/git-d0416149)
  • stlink commandline tool name: [st-info, st-flash, st-util] (e.g st-info, st-flash, st-util)
  • Target chip (and board, if applicable): [N/A] (e.g STM32F103C8T6 (NUCLEO-F103RB))

Further we kindly ask you to describe the detected problem as detailed as possible and to add debug output if available, by using the following template:

I am currently working on improving CI integration for this toolset.
During my work on that topic I found that there is an issue with our flash debug test in /tests/flash.c

Commandline output:

[TEST] Debug
Running tests...
Test project /home/runner/work/stlink/stlink/build/Debug
    Start 1: test-usb
1/3 Test #1: test-usb .........................   Passed    0.01 sec
    Start 2: test-sg
2/3 Test #2: test-sg ..........................   Passed    0.00 sec
    Start 3: test-flash
3/3 Test #3: test-flash .......................***Failed    0.00 sec

67% tests passed, 1 tests failed out of 3

Errors while running CTest
Total Test time (real) =   0.10 sec

The following tests FAILED:
	  3 - test-flash (Failed)
Makefile:170: recipe for target 'test' failed
make[1]: *** [test] Error 8
Makefile:49: recipe for target 'test' failed
make: *** [test] Error 2
Error: Process completed with exit code 2.

@Ant-ON Could it be that there are some missing changes which have found their way into the codebase in the recent weeks?
As you were the main contributor on this topic: Would it be possible for you to have a look at this code?

Thank you for your support.

The stlink project maintainers

@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Mar 27, 2021
@Nightwalker-87 Nightwalker-87 added this to To do in Release v1.7.0 via automation Mar 27, 2021
@Nightwalker-87 Nightwalker-87 changed the title [feature] [Update for CI Integration] [feature] Update for CI integration Mar 27, 2021
@Nightwalker-87 Nightwalker-87 self-assigned this Mar 27, 2021
@Nightwalker-87 Nightwalker-87 moved this from To do to In progress in Release v1.7.0 Mar 27, 2021
@Nightwalker-87
Copy link
Member Author

Nightwalker-87 commented Mar 27, 2021

@slyshykO I managed to get GitHub Actions CI integration running for the available virtual environments running Ubuntu Linux and macOS. We might also be able to include a windows-2019 environment, but I'm not sure if we can achieve that in the first step already. My first impression is, that GitHub Actions CI build jobs are running much faster than the ones on Travis CI.

@Nightwalker-87
Copy link
Member Author

@Ant-ON Thx for looking at tests/flash.c. I'll give it a try.

@Nightwalker-87 Nightwalker-87 moved this from In progress to Review in progress in Release v1.7.0 Mar 27, 2021
@Nightwalker-87
Copy link
Member Author

It works now, but breaks somewhere else now... 😆
Whatsoever - this time I know why and can fix it myself.
It really is a stop and go procedure through the whole build config. 😅

@Nightwalker-87
Copy link
Member Author

Nightwalker-87 commented Mar 27, 2021

ℹ️ The GitHub Actions CI integration workflow is now functional for all variants of our Ubuntu Linux and macOS build configurations which we currently have in Travis CI. For now we should keep Travis CI for this project, but I'll remove build configurations from there that can be equally covered and run by GitHub Actions. This is because some builds are very slow and even a bit unstable on Travis. One may add a windows build environment as well as part of a future release.

@Nightwalker-87 Nightwalker-87 moved this from Review in progress to Reviewer approved in Release v1.7.0 Mar 27, 2021
Release v1.7.0 automation moved this from Reviewer approved to Done Mar 27, 2021
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants