CLI tools need better argument parsing

[smithbone]

The v1/v2 checking code for st-flash is dependent on the number of arguments provided. is listed as an option argument but if you you provide that argument then the argument parser assumes you are talking to a v1 device because 4 arguments are provided.

[gerryqd]

Just checked the code, seems the info is useless when it is in "write" mode.

Anyway, this is a bug.

[xor-gate]

Did you fixed this issue with pull request #413 ? I did review it and seems to be fine. I'm currently not very happy how the option parsing is implemented (for all CLI tools) and it needs some more love and reworking. Thanks for looking into it.

[gerryqd]

Sorry, I did not fix it in #413. Personally, I think the opt parse function should be rewritten. Some cases should be taken into account.

[xor-gate]

Yeah you are right, I will rename this issue because it is major. I take two small option parsing libraries into account which are both MIT license:

• https://github.com/clibs/flag
• or https://github.com/clibs/commander

[xor-gate]

Related to #208

[Nightwalker-87]

@grevaillot: Can you check if this resolves with your recent PR?

[grevaillot]

i'm a bit puzzled by that piece of code, the v1/v2 stlink handling is a bit broken, the device path is not actually used, and i think it's useless now.

still it would be nice to replace the whole custom opt parsing by something more nice / standard..