Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Drop for DMA transfer types #123

Closed
thalesfragoso opened this issue Jul 16, 2020 · 1 comment · Fixed by #230
Closed

Implement Drop for DMA transfer types #123

thalesfragoso opened this issue Jul 16, 2020 · 1 comment · Fixed by #230

Comments

@thalesfragoso
Copy link
Member

Right now the DMA API is unsound, the problem happens if you use a smart pointer (Box, etc) that deallocates on drop. In that case, the DMA will continue the write/read to the invalid region if the user drops the transfer type.

The Drop implementation should stop the DMA. For more information and example see the embedonomicon.

CC @korken89

@korken89
Copy link
Collaborator

This will be fixed in #230 (cont. of #165)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants