Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small but important regression in STM32F411CE Black Pill variant .h file #1369

Closed
AndrewBCN opened this issue Apr 25, 2021 · 0 comments
Closed

Comments

@AndrewBCN
Copy link

There seems to be a small but important regression in release 2.0.0 vs 1.9.0 in the file
Arduino_Core_STM32/variants/STM32F4xx/F411C(C-E)(U-Y)/variant_BLACKPILL_F411CE.h
lines 114-117
// I2C definitions
#ifndef PIN_WIRE_SDA
#define PIN_WIRE_SDA PB3
#endif

PB3 is incorrect, it should be PB7. In release 1.9.0 it was PB7.

I confirmed this with a STM32F411CEU6 Black Pill I am working on these days, running the "I2C scanner" example.

I am not sure if this is a typo, or if the file is automatically generated from some other files, which would mean the regression is somewhere else.

@fpistm fpistm added this to To do in STM32 core based on ST HAL via automation Apr 25, 2021
@fpistm fpistm added this to the 2.x.x milestone Apr 25, 2021
@fpistm fpistm closed this as completed in fa8d1f7 Apr 25, 2021
STM32 core based on ST HAL automation moved this from To do to Done Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants