Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timer] - ONEPULSEMODE defines wrong documentation #1

Closed
scachemaille opened this issue Nov 11, 2020 · 3 comments
Closed

[timer] - ONEPULSEMODE defines wrong documentation #1

scachemaille opened this issue Nov 11, 2020 · 3 comments
Assignees
Labels
hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system

Comments

@scachemaille
Copy link

#define LL_TIM_ONEPULSEMODE_SINGLE TIM_CR1_OPM /*!< Counter is not stopped at update event */
#define LL_TIM_ONEPULSEMODE_REPETITIVE 0x00000000U /*!< Counter stops counting at the next update event */

I think that the comment on these lines are actually inverted..

@ASELSTM ASELSTM self-assigned this Nov 13, 2020
@ASELSTM
Copy link
Collaborator

ASELSTM commented Nov 13, 2020

Hi @scachemaille,

Thank you for this report.

Indeed, the comment are inverted and they should rather be:

-*#define  LL_TIM_ONEPULSEMODE_SINGLE             TIM_CR1_OPM         /*!< Counter is not stopped at update event */ 
+*#define LL_TIM_ONEPULSEMODE_SINGLE             TIM_CR1_OPM         /*!< Counter stops counting at the next update event*/     
-*#define  LL_TIM_ONEPULSEMODE_REPETITIVE        0x00000000U          /*!< Counter stops counting at the next update event*/ 
+*#define LL_TIM_ONEPULSEMODE_REPETITIVE        0x00000000U          /*!< Counter is not stopped at update event */

A bug tracker has been opened internally and the fix will be published in the frame of a future publication. We cannot share a date for the moment. Stay tuned and thank you once more for your contribution and for your patience.

With regards,

@ASELSTM
Copy link
Collaborator

ASELSTM commented Nov 13, 2020

ST Internal Reference: 96303

@ASELSTM ASELSTM added internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system hal HAL-LL driver-related issue or pull-request. labels Nov 13, 2020
@ASELSTM ASELSTM moved this from To do to In progress in stm32cube-mcu-hal-dashboard Nov 13, 2020
@ASELSTM ASELSTM moved this from In progress to To release in stm32cube-mcu-hal-dashboard Dec 11, 2020
@ASELSTM
Copy link
Collaborator

ASELSTM commented Mar 4, 2021

Hi @scachemaille,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.2.1 of the stm32g4xx_hal_driver published recently on GitHub.

Thank you again for having reported.

With regards,

@ASELSTM ASELSTM closed this as completed Mar 4, 2021
stm32cube-mcu-hal-dashboard automation moved this from To release to Done Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Development

No branches or pull requests

2 participants