-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node_group not working in autographr() #11
Comments
I'm not getting this error, but the groups weren't plotting correctly so I changed that |
Thanks @jaeltan, it is working better now. Still, the error persists and can be reproduced with:
|
I just tried this and got a plot without any error https://app.zenhub.com/files/238751844/3d9f3646-ab07-4ccd-9a4f-cca0c4f7a392/download |
Can you try it @henriquesposito to see whether this is a Mac issue? |
I get no errors on my side, I get the same plot as Jael... |
I can reproduce the error and I think it might be related to the release version of Please let me know what you think @jhollway . Another alternative could be to require certain package versions in the description file. However, I am not sure how this will affect previous changes in argument names, for example, with the new versions of |
I'm travelling again, but can you please show here/on Slack what the differences would be visually between hulls and ellipses? What's at stake in the choice? |
Running I have been able to make the function work better with the ellipses (below). @jhollway please let me know what you think. |
Honestly, neither really looks all that helpful. Does the |
I understand, I will go back to it and try to find a better alternative. "node_group" expects a variable in the data to be declared, it could be character or numeric, and the argument is treated as a factor. |
I have been looking more into this issue and the fix might be more complicated then first taught (see https://github.com/thomasp85/ggforce/issues for this and other related issues). Some alternatives to move forward (ordered by difficulty): 1- We could use a temporary fix for now (e.g. ellipses/polygons) and wait until the respective functions on 2- We can alter the layout when the 'node_group' argument is declared to improve community visualisation. For instance, we can use network backbones to better place nodes from the same community near(ish) each other (see http://blog.schochastics.net/post/ggraph-tricks-for-common-problems/ and http://blog.schochastics.net/post/introducing-graphlayouts-with-got/) and improve visuals. Though this way we might still have to handle issues with 3- We can try and create our own custom "hull" function to visualise communities. @jhollway please let me know what you think. Thank you. |
I will suspend this functionality momentarily and go back to it when the issues in ggforce are solved. |
This issue has been fixed by limiting the number of categories group variables can have when plotting with |
Gives an
anchors[[1]]: subscript out of bounds
error.The text was updated successfully, but these errors were encountered: