Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Using elm-tools/parser for parsing #36

Closed
ohanhi opened this issue Jun 19, 2017 · 3 comments
Closed

Proposal: Using elm-tools/parser for parsing #36

ohanhi opened this issue Jun 19, 2017 · 3 comments

Comments

@ohanhi
Copy link
Contributor

ohanhi commented Jun 19, 2017

At the moment elm-verify-examples is using Regex for parsing the doc comment contents. elm-tools/parser seems like a very nice way to parse things in Elm.

Do you think it would be an interesting experiment if I tried rewriting (at least a part of) the parsing using that library instead of regular expressions?

@eeue56
Copy link
Collaborator

eeue56 commented Jun 19, 2017

Go for it, but be sure to benchmark. See this PR for more info: #9

@stoeffel
Copy link
Owner

I was thinking about doing that as well. Please go for it!

@gampleman
Copy link
Collaborator

The plan here is to adopt still4m/elm-syntax, but there is some work needed to expose the kinds of parsers we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants