Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject the attribute reader in place of the annotations reader when able #481

Closed
mbabker opened this issue Mar 20, 2024 · 0 comments · Fixed by #486
Closed

Inject the attribute reader in place of the annotations reader when able #481

mbabker opened this issue Mar 20, 2024 · 0 comments · Fixed by #486
Labels

Comments

@mbabker
Copy link

mbabker commented Mar 20, 2024

The setAnnotationReader() method on the event listeners accepts either a Doctrine\Common\Annotations\Reader or a Gedmo\Mapping\Driver\AttributeReader, and after doctrine-extensions/DoctrineExtensions#2743 the attribute reader is (rightfully) no longer considered internal. The bundle should be updated to provide the attribute reader when appropriate to avoid relying on the library's feature detection (which will default to annotations if doctrine/annotations is installed, even if Symfony doesn't have an annotation_reader service).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant