Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Mode not working for new tabs (when "New tabs" is set to "Blank Page" in Firefox) #332

Closed
keganlance opened this issue Dec 1, 2019 · 6 comments

Comments

@keganlance
Copy link

The automatic mode behaviour changed with the last 30 november update.

How it worked before:
You open a new tab, the addon creates a new session container tab and closes the new tab.

How it works now with the 30 november update:
You open a new tab, nothing happens. Only when you then go to some website, it opens in a new container.

Problems with this behaviour are:

  • Certain reserved domains like addons.mozilla.org don't open in a new session container
  • This breaks search engines which use post requests as the post request is lost when the addon changes the container.

Is there any way we can get back to the behaviour before the 30 november update?

@stoically
Copy link
Owner

Do you have "new tabs" set to "Blank page" in the Firefox preferences? If so: Unfortunately it's not reliably possible to detect new tabs that are set to "Blank page", in order to reopen them in a TC, without introducing a lot of possible side-effects (#311, #321). So the only fix, unless we get an API from Firefox to detect new "Blank page" tabs, is to set it to "Firefox Home" instead.

@keganlance
Copy link
Author

Thanks your your quick reply! I indeed have it set to about:blank. Just changed to about:home and solves the issue. Thanks for explaining why about:blank is an issue. And thanks for this wonderful addon!

@stoically
Copy link
Owner

stoically commented Dec 1, 2019

Glad you like it and that about:home works for you! I'll look into opening a Bugzilla ticket and ask for the needed API.

Until then there's a note about the behavior in the wiki.

@stoically stoically pinned this issue Dec 1, 2019
@stoically stoically changed the title No automatic new container on new tab Automatic Mode not working for new tabs Dec 1, 2019
@grahamperrin
Copy link

… I'll look into opening a Bugzilla ticket and ask for the needed API. …

https://old.reddit.com/r/waterfox/comments/fzn7rw/-/fn5ytgy/ there's a note of the feature working with Firefox versions 74 and 75.0.

@stoically should this issue remain pinned? For users of Firefox ESR 68, maybe?

@stoically stoically changed the title Automatic Mode not working for new tabs Automatic Mode not working for new tabs (when "New tabs" is set to "Blank Page" in Firefox) Apr 16, 2020
@stoically
Copy link
Owner

@grahamperrin The issue unfortunately persists. Updated the title to clarify what this is about.

@ghost
Copy link

ghost commented Jan 17, 2022

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants