Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ManagedClusterSet labeling when creating ClusterPools #116

Open
gurnben opened this issue Sep 7, 2021 · 0 comments
Open

Comments

@gurnben
Copy link
Member

gurnben commented Sep 7, 2021

Summary of Request

ACM 2.3 adds support for ManagedClusterSets that allow you to federate access to ClusterPools, ClusterDeployments, and ClusterClaims. It also adds admission requirements for non-admin users to place their ClusterPool into a ManagedClusterSet, so its important that we support adding ClusterPools and Deployments at create time to a ManagedClusterSet.

I would suggest that we add an optional parameter to the create command for ClusterDeployments and ClusterPools, something like --cluster-set/-cs that allows you to provide a ManagedClusterSet name. That parameter will be translated into a label in the .metadata.labels list in the ClusterPool or ClusterDeployment YAML to apply.

The label in question should be added to .metadata.labels with the key:value pair cluster.open-cluster-management.io/clusterset:<MANAGEDCLUSTERSET_NAME>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant